Assignment 5 (Error Handling in Car Accident scenario)#5
Open
mukulpalol16 wants to merge 8 commits intomainfrom
Open
Assignment 5 (Error Handling in Car Accident scenario)#5mukulpalol16 wants to merge 8 commits intomainfrom
mukulpalol16 wants to merge 8 commits intomainfrom
Conversation
Poyam-ITT
reviewed
Apr 2, 2024
nansi-maheshwari-ITT
approved these changes
Apr 3, 2024
| { | ||
| Console.WriteLine("Car is running."); | ||
| DrivingScenario scenario = (DrivingScenario)new Random().Next(1, 6); // Simulate random car failure/accident scenarios | ||
| switch (scenario) |
Collaborator
There was a problem hiding this comment.
Can it be done without switch case as it breaks OCP.
Owner
Author
There was a problem hiding this comment.
I have used switch case just so I can simulate different accident scenarios randomly. In actual case, we would have a method inside the Run method which will throw any of the exceptions that we'll get.
Let me know what you think about it.
Collaborator
There was a problem hiding this comment.
Then it is ok else everything looks good to me.
namankhamesra
approved these changes
Apr 3, 2024
PradeepITT
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.