Skip to content

fix(settings): support multiple GitHub installations#5621

Draft
Bbbtt04 wants to merge 5 commits into
multica-ai:mainfrom
Bbbtt04:fix/5599-github-multi-installations
Draft

fix(settings): support multiple GitHub installations#5621
Bbbtt04 wants to merge 5 commits into
multica-ai:mainfrom
Bbbtt04:fix/5599-github-multi-installations

Conversation

@Bbbtt04

@Bbbtt04 Bbbtt04 commented Jul 18, 2026

Copy link
Copy Markdown

Summary

  • Render every GitHub App installation as an independently managed row with avatar, account type, and connector attribution.
  • Keep Connect another GitHub available after the first installation and disconnect the exact selected row by UUID.
  • Validate the installation list response with a forward-compatible schema and expose connected_by through the existing endpoint.

Root cause

The settings UI collapsed the installations array into a single connected state, hid the connect action, and always targeted installations[0]. The API also retained connected_by_id without exposing the connector name needed by the multi-row UI.

Permissions and behavior

  • Owners and admins can connect and disconnect installations.
  • Regular members see the complete read-only list without receiving numeric GitHub installation handles.
  • Disconnect remains available when the workspace-level GitHub feature switch is off.
  • Unknown future GitHub account types remain displayable instead of invalidating the list response.

Verification

  • @multica/views: 234 test files, 2683 tests passed.
  • @multica/core: 91 test files, 989 tests passed.
  • Views and core TypeScript checks passed.
  • Targeted ESLint checks passed.
  • Full Go handler tests and go vet ./internal/handler passed.
  • All four locale JSON files and git diff --check passed.
  • Local Chrome flow passed with two seeded installations at desktop width and 394 px; the second row opened its own account-specific disconnect dialog and was cancelled without deleting data.

Closes #5599

Bbbtt04 added 5 commits July 18, 2026 15:37
AI-Generated: true
AI-Author: wangbinteng
AI-Team: multica-ai
AI-Model: unknown
AI-Agent: codex
AI-Timestamp: 2026-07-18T07:37:13Z
AI-Generated: true
AI-Author: wangbinteng
AI-Team: multica-ai
AI-Model: unknown
AI-Agent: codex
AI-Timestamp: 2026-07-18T07:40:01Z
AI-Generated: true
AI-Author: wangbinteng
AI-Team: multica-ai
AI-Model: unknown
AI-Agent: codex
AI-Timestamp: 2026-07-18T07:52:42Z
AI-Generated: true
AI-Author: wangbinteng
AI-Team: multica-ai
AI-Model: unknown
AI-Agent: codex
AI-Timestamp: 2026-07-18T08:37:27Z
AI-Generated: true
AI-Author: wangbinteng
AI-Team: multica-ai
AI-Model: unknown
AI-Agent: codex
AI-Timestamp: 2026-07-18T08:42:49Z
@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

@Bbbtt04 is attempting to deploy a commit to the IndexLabs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Settings → GitHub hides Connect after first install and only disconnects the first installation

1 participant