MUL-4971: Fix sub-issue attention escalation (ZIC-99)#5625
Open
vicksiyi wants to merge 1 commit into
Open
Conversation
Co-authored-by: multica-agent <github@multica.ai>
|
@vicksiyi is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a stall in sub-issue orchestration where child issues entering
in_revieworblockedonly produced ordinary status-change notifications. Parent coordinators could miss those states unless they were subscribed to the child/parent issue.This adds a parent-level handoff for child review/block states, reusing the existing child-complete routing model: a system comment is posted on the parent, agent/squad parent assignees are woken through the existing deduped task path, and member parent assignees receive an action-required inbox item pointing at the child.
Related Issue
Closes #5464
Multica issue: ZIC-99
Type of Change
Changes Made
in_review/blockedparent handoffs inserver/internal/handler/issue_child_done.go.How to Test
cd servergo test ./internal/handler -run 'TestChildAttention|TestBatchChildAttention|TestChildDone|TestBatchChildDone'go test ./internal/handlerNote:
make check-worktreeexited 0 locally, but its PostgreSQL check printed that Docker was unavailable at/Users/icezero/.docker/run/docker.sock, so the meaningful local validation is the Go handler test suite above.Checklist
apps/web/features/landing/i18n/) and relevant docs (apps/docs/content/docs/)apps/docs/content/docs/developers/conventions.zh.mdx(terminology, mixed-rule fortask/issue/skill)AI Disclosure
AI tool used: Multica Agent
Prompt / approach:
Investigated GitHub #5464 and the existing child-done parent handoff path, then added the smallest backend change to surface child review/block states without changing terminal stage-barrier behavior.
Screenshots (optional)
N/A