Skip to content

Fix project detail mobile panel layout crash#5626

Open
vicksiyi wants to merge 1 commit into
multica-ai:mainfrom
vicksiyi:multica-fix/issue-3626-panel-layout-resize
Open

Fix project detail mobile panel layout crash#5626
vicksiyi wants to merge 1 commit into
multica-ai:mainfrom
vicksiyi:multica-fix/issue-3626-panel-layout-resize

Conversation

@vicksiyi

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes a responsive crash in the project detail page where the mobile path kept ResizablePanelGroup mounted while only the content panel was rendered. If react-resizable-panels restored a saved desktop two-panel layout during a resize, the group could validate it against one mounted panel and throw Invalid 1 panel layout.

The mobile project detail path now renders the main content directly and keeps the sidebar in the mobile sheet, matching the issue detail pattern. Desktop still renders the two-panel resizable group with the restored layout.

Related Issue

Closes #3626

Multica issue: ZIC-96

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Refactor / code improvement (no behavior change)
  • Tests (adding or improving test coverage)
  • Documentation update
  • CI / infrastructure

Changes Made

  • Updated packages/views/projects/components/project-detail.tsx so mobile renders without ResizablePanelGroup, avoiding one-panel group validation against restored two-panel state.
  • Added packages/views/projects/components/project-detail.test.tsx coverage for the mobile no-panel-group path and the desktop persisted split-panel path.

How to Test

  1. pnpm --filter @multica/views exec vitest run projects/components/project-detail.test.tsx
  2. pnpm --filter @multica/views typecheck
  3. pnpm --filter @multica/views lint

Notes:

  • pnpm --filter @multica/views lint exits 0 with existing warnings.
  • make check-worktree was attempted, but local Docker is not running, so the PostgreSQL preflight printed Cannot connect to the Docker daemon before the full pipeline could run.

Checklist

  • I have included a thinking path that traces from project context to this change
  • I have run tests locally and they pass
  • I have added or updated tests where applicable
  • If this change affects the UI, I have included before/after screenshots
  • I have updated relevant documentation to reflect my changes
  • If I added a new runtime / coding tool / UI tab, I synced the change to landing copy (apps/web/features/landing/i18n/) and relevant docs (apps/docs/content/docs/)
  • If this PR touches Chinese product copy, I checked it against apps/docs/content/docs/developers/conventions.zh.mdx (terminology, mixed-rule for task / issue / skill)
  • I have considered and documented any risks above
  • I will address all reviewer comments before requesting merge

AI Disclosure

AI tool used: Multica Agent

Prompt / approach:
Traced react-resizable-panels usage around responsive detail layouts, identified ProjectDetail as the path that could render a one-panel group with restored two-panel state, applied the existing mobile sheet pattern from issue detail, and added focused regression coverage.

Screenshots (optional)

Not applicable; this is a responsive crash guard with no visual behavior change intended.

Co-authored-by: multica-agent <github@multica.ai>
@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

@vicksiyi is attempting to deploy a commit to the IndexLabs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop app shows Invalid 1 panel layout error when resizing down

1 participant