Fix project detail mobile panel layout crash#5626
Open
vicksiyi wants to merge 1 commit into
Open
Conversation
Co-authored-by: multica-agent <github@multica.ai>
|
@vicksiyi is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a responsive crash in the project detail page where the mobile path kept
ResizablePanelGroupmounted while only the content panel was rendered. Ifreact-resizable-panelsrestored a saved desktop two-panel layout during a resize, the group could validate it against one mounted panel and throwInvalid 1 panel layout.The mobile project detail path now renders the main content directly and keeps the sidebar in the mobile sheet, matching the issue detail pattern. Desktop still renders the two-panel resizable group with the restored layout.
Related Issue
Closes #3626
Multica issue: ZIC-96
Type of Change
Changes Made
packages/views/projects/components/project-detail.tsxso mobile renders withoutResizablePanelGroup, avoiding one-panel group validation against restored two-panel state.packages/views/projects/components/project-detail.test.tsxcoverage for the mobile no-panel-group path and the desktop persisted split-panel path.How to Test
pnpm --filter @multica/views exec vitest run projects/components/project-detail.test.tsxpnpm --filter @multica/views typecheckpnpm --filter @multica/views lintNotes:
pnpm --filter @multica/views lintexits 0 with existing warnings.make check-worktreewas attempted, but local Docker is not running, so the PostgreSQL preflight printedCannot connect to the Docker daemonbefore the full pipeline could run.Checklist
apps/web/features/landing/i18n/) and relevant docs (apps/docs/content/docs/)apps/docs/content/docs/developers/conventions.zh.mdx(terminology, mixed-rule fortask/issue/skill)AI Disclosure
AI tool used: Multica Agent
Prompt / approach:
Traced
react-resizable-panelsusage around responsive detail layouts, identifiedProjectDetailas the path that could render a one-panel group with restored two-panel state, applied the existing mobile sheet pattern from issue detail, and added focused regression coverage.Screenshots (optional)
Not applicable; this is a responsive crash guard with no visual behavior change intended.