Skip to content

fix(comments): preserve suppression through reconciliation#5633

Draft
S1lash wants to merge 1 commit into
multica-ai:mainfrom
S1lash:agent/durable-comment-suppression
Draft

fix(comments): preserve suppression through reconciliation#5633
S1lash wants to merge 1 commit into
multica-ai:mainfrom
S1lash:agent/durable-comment-suppression

Conversation

@S1lash

@S1lash S1lash commented Jul 19, 2026

Copy link
Copy Markdown

What changed

  • persist suppress_agent_ids as internal comment routing metadata
  • reapply exact-agent suppression when completion reconciliation revisits an undelivered comment
  • deduplicate suppression IDs before storage while continuing to reject malformed UUIDs at the request boundary
  • define edit semantics: content edits replace suppression; content-preserving updates retain it
  • update the built-in mentioning skill and source map for the durable contract
  • add production-path DB regressions and regenerate sqlc projections

Why

A comment can be posted while its target already has an active task. Immediate routing honors suppress_agent_ids, but completion reconciliation may revisit the same undelivered comment after that task becomes terminal. Suppression previously existed only on the request, so the delayed path could turn an explicit no-wake decision into a redundant follow-up run.

Suppression is now part of the comment's durable routing action. Immediate routing and delayed reconciliation therefore make the same exact-agent decision across retries and process restarts. Unrelated agents, explicit mentions not present in the suppression set, and ordinary comments with no suppression metadata keep their existing behavior.

The field remains internal: comment API responses are built through CommentResponse and do not expose suppressed_agent_ids.

Design

The metadata lives on comment because reconciliation already replays saved comments as its durable unit. A separate delivery relation would add lifecycle and cleanup complexity without improving the only lookup required here, while repository rules intentionally avoid database foreign keys. A UUID array matches the bounded set-valued routing contract and requires no index because it is read only with the reconciled comment row.

A content edit is a new routing action and replaces the stored suppression set; omitting the field on such an edit intentionally clears it. Attachment-only or otherwise content-preserving updates retain the original suppression contract.

Validation

  • clean schema migration from 001 through 202
  • full migration down/up round trip on a disposable database
  • focused handler regressions with -race, including real create-handler persistence and delayed reconciliation
  • go test -race across the full Go suite, with pkg/agent run under the repository's bounded parallelism
  • final go test ./...
  • deterministic make sqlc with no generated diff
  • git diff --check

@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the IndexLabs Team on Vercel.

A member of the Team first needs to authorize it.

@S1lash
S1lash force-pushed the agent/durable-comment-suppression branch from 4a7d107 to 92eab64 Compare July 19, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant