fix(comments): preserve suppression through reconciliation#5633
Draft
S1lash wants to merge 1 commit into
Draft
Conversation
|
Someone is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
S1lash
force-pushed
the
agent/durable-comment-suppression
branch
from
July 19, 2026 10:23
4a7d107 to
92eab64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
suppress_agent_idsas internal comment routing metadataWhy
A comment can be posted while its target already has an active task. Immediate routing honors
suppress_agent_ids, but completion reconciliation may revisit the same undelivered comment after that task becomes terminal. Suppression previously existed only on the request, so the delayed path could turn an explicit no-wake decision into a redundant follow-up run.Suppression is now part of the comment's durable routing action. Immediate routing and delayed reconciliation therefore make the same exact-agent decision across retries and process restarts. Unrelated agents, explicit mentions not present in the suppression set, and ordinary comments with no suppression metadata keep their existing behavior.
The field remains internal: comment API responses are built through
CommentResponseand do not exposesuppressed_agent_ids.Design
The metadata lives on
commentbecause reconciliation already replays saved comments as its durable unit. A separate delivery relation would add lifecycle and cleanup complexity without improving the only lookup required here, while repository rules intentionally avoid database foreign keys. A UUID array matches the bounded set-valued routing contract and requires no index because it is read only with the reconciled comment row.A content edit is a new routing action and replaces the stored suppression set; omitting the field on such an edit intentionally clears it. Attachment-only or otherwise content-preserving updates retain the original suppression contract.
Validation
-race, including real create-handler persistence and delayed reconciliationgo test -raceacross the full Go suite, withpkg/agentrun under the repository's bounded parallelismgo test ./...make sqlcwith no generated diffgit diff --check