avoid constructor.name pattern #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yahya <[email protected]>
dryajov
approved these changes
Mar 8, 2018
|
Thanks a lot @ya7ya. I just changed the commit message to match the JS Code Guidelines. |
daviddias
reviewed
Mar 9, 2018
| @@ -415,7 +415,7 @@ Multiaddr.protocols = protocols | |||
| */ | |||
| Multiaddr.isMultiaddr = function isMultiaddr (addr) { | |||
| if (addr.constructor && addr.constructor.name) { | |||
| return addr.constructor.name === 'Multiaddr' | |||
There was a problem hiding this comment.
Wait, this will fail terribly when we have multiple versions of Multiaddr flying around. Which happens often given the myriad of modules we have that import Multiaddr and also the user apps.
daviddias
reviewed
Mar 9, 2018
| @@ -415,7 +415,7 @@ Multiaddr.protocols = protocols | |||
| */ | |||
| Multiaddr.isMultiaddr = function isMultiaddr (addr) { | |||
| if (addr.constructor && addr.constructor.name) { | |||
| return addr.constructor.name === 'Multiaddr' | |||
| return (addr instanceof Multiaddr) | |||
There was a problem hiding this comment.
|
@diasdavid Sorry I thought the revert was already merged, but it was only approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to fix ipfs/js-ipfs#1131 properly.
cc @diasdavid
Signed-off-by: Yahya [email protected]