Added DBus calls to activate and deactivate push to talk #3675
Conversation
|
Could you squash the two commits, please? |
|
Thank you very much for your contribution! |
|
You're welcome. Thanks a bunch for your help both getting this merged and with understanding the codebase! |
|
You're welcome! |
…rface If mumble isn't allowed to listen to all input from an input device, for example when running as wayland client, ptt events can be sent via socket rpc, and, in the case of wayland, the keybinding can be done by the compositor. mumble-voip#3675 implements this for dbus. To avoid executing the rather large mumble binary to do the rpc, one could also do something like this: echo '<self><starttalking>starttalking</starttalking></self>' | socat - UNIX-CONNECT:/tmp/MumbleSocket Implements mumble-voip#1594
|
Is it possible to do this with a regular key instead of a mouse button? |
|
@aconitumnapellus Yeah, I think the With regard to it getting stuck in the on state, I just played around with it and was able to reproduce that inconsistently locally. I'm not really sure what the root issue there is. It really could be anything from an issue in Sway, dbus, or Mumble. I would suggest you open a separate issue to discuss it getting stuck. I wonder if it is related to this issue: #4154. Seems like the problem might be somewhere in the middle of the chain though, I'm not sure. |
This code is from part of the solution for push to talk support on Wayland presented by @detrout in #3243.
This PR:
This change coupled with a binding (example for sway below) allows usage of push to talk on Wayland. Gnome, Plasma, and Sway all seem to support triggering arbitrary shell commands with a hotkey. Due to the lack of a Wayland protocol for keyboard shortcut registration this seems to be a good workaround.