Add gettext to Dockerfile dependencies#4
Merged
Merged
Conversation
* Add gettext-base to Dockerfile dependencies * Implement msgfmt availability and translation tests Added tests for msgfmt availability and translation compilation. * Refactor Dockerfile to adjust gettext-base dependency Removed 'gettext-base' from the builder stage and added it to the runtime dependencies. * Refactor msgfmt checks and add translation test Updated msgfmt availability checks to run in container and added translation compilation test. * Update test.sh * Modify docker build and add gettext verification Updated docker compose commands to include --no-cache and added verification steps for gettext-base in the test image. * set gettext in base image and remove from builder * add gettext domain and locale to metadata * correct .po path * remove unneeded step in text container
Contributor
Author
|
Hi @murar8 |
murar8
requested changes
Mar 20, 2026
Owner
murar8
left a comment
murar8
left a comment
There was a problem hiding this comment.
Review
Dockerfile change is correct, CI passes. Two minor items:
1. find || echo diagnostic is dead code (test.sh:103)
find exits 0 even with no results, so echo "No .mo files found" never runs:
$ mkdir -p /tmp/empty && find /tmp/empty -name "*.mo" || echo "not found"
$ echo $?
0
# "not found" is never printed2. No cleanup of test-extension/po/ (test.sh)
The cleanup() trap doesn't remove test-extension/po/, leaving untracked files after local test runs.
Owner
|
Hi @jbellue apart from those things I think if it fixes your issue we can get it in! |
Contributor
Author
|
Hi @murar8 - of course! Sorry about these! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: add gettext support for translation compilation
gnome-extensions packfailed withmsgfmt: No such file or directorywhen processing.pofiles.Changes
gettexttobasestage (provides/usr/bin/msgfmtruntime).po→.mocompilation:test-extension/po/test-extension.poINPUT_GETTEXT_DOMAIN+INPUT_PODIRlocale/test-extension/LC_MESSAGES/test-extension.mooutputBefore
After
Proof
Actions run shows all tests passing on my fork