Add rtti option #343
Merged
Add rtti option #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
Comment on lines
50
to
74
| add_library(${PROJECT_NAME} SHARED | ||
| src/cpp/rtc-wrapper.cpp | ||
| src/cpp/media-direction.cpp | ||
| src/cpp/media-rtcpreceivingsession-wrapper.cpp | ||
| src/cpp/media-track-wrapper.cpp | ||
| src/cpp/media-audio-wrapper.cpp | ||
| src/cpp/media-video-wrapper.cpp | ||
| src/cpp/data-channel-wrapper.cpp | ||
| src/cpp/peer-connection-wrapper.cpp | ||
| src/cpp/thread-safe-callback.cpp | ||
| src/cpp/web-socket-wrapper.cpp | ||
| src/cpp/web-socket-server-wrapper.cpp | ||
| src/cpp/main.cpp | ||
| ${CMAKE_JS_SRC} | ||
| ) | ||
|
|
||
| if(NOT NO_MEDIA) | ||
| target_sources(${PROJECT_NAME} PRIVATE | ||
| src/cpp/media-direction.cpp | ||
| src/cpp/media-rtcpreceivingsession-wrapper.cpp | ||
| src/cpp/media-track-wrapper.cpp | ||
| src/cpp/media-audio-wrapper.cpp | ||
| src/cpp/media-video-wrapper.cpp | ||
| ) | ||
| endif() | ||
|
|
||
| if(NOT NO_WEBSOCKET) | ||
| target_sources(${PROJECT_NAME} PRIVATE | ||
| src/cpp/web-socket-wrapper.cpp | ||
| src/cpp/web-socket-server-wrapper.cpp | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
This update is giving error: 'napi.h' file not found
There was a problem hiding this comment.
Sorry for this part.
Actually, it is part of another PR but harmless.
error: 'napi.h' file not found when I see this error, I need to delete the build folder and re-compile the project.
So not related to here, I think.
Comment on lines
+24
to
+26
| if (NOT CMAKE_SYSTEM_NAME STREQUAL "Windows") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -frtti") | ||
| endif() |
There was a problem hiding this comment.
It's working on linux but getting the same error for intel mac architecture.
There was a problem hiding this comment.
Here, it is saying wrong architecture.
need x86 but have arm64.
It should not be related to this issue.
akhileshthite
approved these changes
Mar 29, 2025
This was referenced Apr 5, 2025
Adds No_MEDIA and NO_WEBSOCKET options
|
@murat-dogan Hi, could you please publish a new release that includes the RTTI fix? cc @achingbrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #332