Add new lyric in separate undo command #30228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Oct 2, 2025
Screencast_20251003_130201.webmCrashes, enigmatically, when trying to NB: the 4.6.1 port (#30269) does not crash. |
miiizen
force-pushed
the
30187-missingMelisma
branch
from
9ebcf5a to
d050020
Compare
This was referenced Oct 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30187
When rolling back the undo command which added the empty text in
endEditText()at the top ofaddMelisma()we were also rolling back any property changes made in the command between L7631 and L7692. Adding the next lyric needs to happen in a separate command.