Skip to content

Fixed a crash when accessing an invalid json object #30238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2025
Merged

Fixed a crash when accessing an invalid json object #30238

merged 1 commit into from
Oct 6, 2025

Conversation

@Eism
Copy link
Contributor

@Eism Eism commented Oct 2, 2025 

0   MuseScore4.exe                  0x7ff7672452d9      muse::JsonObject::empty (json.cpp:605)
1   MuseScore4.exe                  0x7ff768a1b87e      mu::musesounds::MuseSoundsRepository::parseSounds (musesoundsrepository.cpp:154)
2   MuseScore4.exe                  0x7ff768a25d12      mu::musesounds::MuseSoundsRepository::th_requestSounds (musesoundsrepository.cpp:142)
3   MuseScore4.exe                  0x7ff768a21c1a      QtConcurrent::StoredFunctionCall<T>::runFunctor (qtconcurrentstoredfunctioncall.h:121)
4   MuseScore4.exe                  0x7ff7673a0d50      QtConcurrent::RunFunctionTaskBase<T>::run (qtconcurrentrunbase.h:84)

@Eism Eism requested a review from igorkorsukov October 2, 2025 14:00
@Eism Eism moved this to In Progress in MuseScore Studio 4.6.1 Oct 2, 2025
@Eism Eism mentioned this pull request Oct 2, 2025
Merged
cbjeukendrup
cbjeukendrup reviewed Oct 2, 2025
View reviewed changes
@cbjeukendrup cbjeukendrup added the P1 Priority: High label Oct 2, 2025
igorkorsukov
igorkorsukov reviewed Oct 3, 2025
View reviewed changes
igorkorsukov
igorkorsukov reviewed Oct 3, 2025
View reviewed changes
@Eism Eism force-pushed the muse_sounds_json_crash_fix branch from 0f0fc32 to 15522c4 Compare October 3, 2025 07:19
@Eism Eism force-pushed the muse_sounds_json_crash_fix branch from 15522c4 to ce5e51e Compare October 3, 2025 07:21
@Eism Eism merged commit 2a4dc3a into musescore:master Oct 6, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Needs porting in MuseScore Studio 4.6.1 Oct 6, 2025
@Eism Eism deleted the muse_sounds_json_crash_fix branch October 6, 2025 09:52
@RomanPudashkin RomanPudashkin moved this from Needs porting to Done in MuseScore Studio 4.6.1 Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup left review comments

@igorkorsukov igorkorsukov igorkorsukov approved these changes

Assignees

No one assigned

Labels

P1 Priority: High

Projects

No open projects
MuseScore Studio 4.6.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eism @igorkorsukov @cbjeukendrup