Text positioning refinements #31017
Text positioning refinements #31017
Conversation
|
Looks nice to me! A couple tiny tiny things: The tooltip copy in Style for center-aligning the text box says "Horizontally center text box on reference point" but "on" should be "to" to match properties and the other tooltip copy. Also, could you tweak the vertical spacing between the rows of buttons in both spots plz? Horizontal spacing can stay as-is.
|
miiizen
force-pushed
the
textAlignRefine
branch
from
4d742f0 to
e3b3442
Compare
|
Nice! All good to me. |
ghost
added
the
ghost
requested a review
from 
src/engraving/dom/textbase.cpp
Outdated
| return false; | ||
| } | ||
|
|
||
| bool useBl = isMarker() || isJump() || isRehearsalMark() || isMeasureNumber() || isPlayCountText(); |
There was a problem hiding this comment.
What does Bl stand for? The naming is a bit obscure and in general this reads a bit wonky with all the negations, although there may not be clearer way to express the condition
There was a problem hiding this comment.
Barline - took me a second to work it out too! I've made this more clear
miiizen
force-pushed
the
textAlignRefine
branch
from
e3b3442 to
079ff34
Compare
src/engraving/dom/textbase.cpp
Outdated
| || parent()->isSpannerSegment(); | ||
|
|
||
| return !relativeToBarline && !harmonyRelativeToBarline && !textRelativeToBarline && !noPositionControl; | ||
| } |
There was a problem hiding this comment.
Reads a bit better now, but may I suggest rewriting this in some form like:
switch (type()) {
case ElementType::MARKER:
case ElementType::JUMP:
case ElementType::MEASURE_NUMBER:
case ElementType::PLAY_COUNT_TEXT:
return false;
case ElementType::HARMONY:
return !parent()->isFretDiagram();
case ElementType::SOMETHING_ELSE:
return somethingElse;
default:
return basicConditions;
}
Cause it still reads weird to be definining a "relative to noteheade" property as "not relative to barline". Besides, those are a lot of boolean checks, a switch should be a bit more efficient (though I'm sure it hardly matters here).
There was a problem hiding this comment.
In fact, a purist would say that this should be a virtual method and specific TextBase classes should implement their own versions. Either way is fine for me, I'll leave it up to you :)
Change tooltips in inspector Refine align and position buttons in edit style Fix button spacing Add vtest Migrate old scores Refactor `positionRelativeToNoteheadRest`
miiizen
force-pushed
the
textAlignRefine
branch
from
6f16cce to
b13bd58
Compare
3 participants
Refinements to inspector controls and text style dialog controls.
Also, aligns the left/center/right of the text box to the left/center/right of the note it's being aligned to.
Screen.Recording.2025-11-13.at.15.37.54.mov