Adds protocol handler for MongoDB #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glaslos If there are any changes required, I'm ready to modify my implementation. |
Boolean-Autocrat
force-pushed
the
mongodb
branch
2 times, most recently
from
f61aa61 to
b86d95d
Compare
Boolean-Autocrat
force-pushed
the
mongodb
branch
from
b86d95d to
401d6a1
Compare
|
@glaslos I've rebased my branch onto the latest main to keep the commit history linear. The PR should now be cleaner and ready for review. Let me know if I need to make any changes. Thanks. |
glaslos
approved these changes
Mar 21, 2025
Comment on lines
+94
to
+121
| messageLength := binary.LittleEndian.Uint32(snip) | ||
| if messageLength > 0 && messageLength <= 48*1024*1024 { | ||
| moreSample, bufConn, err := Peek(bufConn, 16) | ||
| if err != nil { | ||
| if err := conn.Close(); err != nil { | ||
| log.Error("failed to close connection", producer.ErrAttr(err)) | ||
| } | ||
| log.Debug("failed to peek connection", producer.ErrAttr(err)) | ||
| return nil | ||
| } | ||
| if len(moreSample) == 16 { | ||
| opCode := binary.LittleEndian.Uint32(moreSample[12:16]) | ||
| validOpCodes := map[uint32]bool{ | ||
| 1: true, // OP_REPLY | ||
| 2001: true, // OP_UPDATE | ||
| 2002: true, // OP_INSERT | ||
| 2004: true, // OP_QUERY | ||
| 2005: true, // OP_GET_MORE | ||
| 2006: true, // OP_DELETE | ||
| 2007: true, // OP_KILL_CURSORS | ||
| 2012: true, // OP_COMPRESSED | ||
| 2013: true, // OP_MSG | ||
| } | ||
| if _, ok := validOpCodes[opCode]; ok { | ||
| return tcp.HandleMongoDB(ctx, bufConn, md, log, h) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We should move this somewhere else. But it is not important right now.
namay26
pushed a commit
to namay26/glutton
that referenced
this pull request
Mar 24, 2025
* [feat] adds protocol handler for MongoDB * [refactor] makes mongo message header private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
This PR adds support for detecting and responding to MongoDB connection attempts.
Changes:
protocols/tcp/mongodb.go)protocols/tcp/mongodb_test.go)protocols/protocols.goconfig/rules.yamlI have referred to the MongoDB Wire Protocol from their documentation which can be found here. I've taken the message header format and the Opcodes from here.
The implementation includes unit tests for both the response creation function and the handler itself with mocked dependencies. The tests verify that the handler correctly processes Mongo protocol messages and generates valid responses.
The handler in action:
on running
mongo --host localhost --port 5000