Skip to content

[fix] Fix errors in lecture 12 code #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] Fix errors in lecture 12 code #12

wants to merge 1 commit into from

Conversation

dhunstack
Copy link
Contributor

Path for GTZAN dataset added in comments.
Following fixes were done -

  • Add error handling during audio load to handle erroneous mp3 files
  • Update positional arguments in librosa.feature.mfcc to keyword arguments

@dhunstack
[fix] Fix errors in lecture 12 code
b9b69e6 
Path for GTZAN dataset added in comments.
Following fixes were done -
 - Add error handling during audio load to handle erroneous `mp3` files
 - Update positional arguments in `librosa.feature.mfcc` to keyword
   arguments

Signed-off-by: Anmol Mishra <[email protected]>
musikalkemist
musikalkemist reviewed Dec 23, 2024
View reviewed changes
Copy link
Owner

@musikalkemist musikalkemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Except block, I'd suggest to print info about the file(s) that couldn't be loaded, so the programme doesn't skip files silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musikalkemist musikalkemist musikalkemist left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhunstack @musikalkemist