Skip to content

Fix issue when reading composite packages #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ia3andy merged 1 commit into from
Jan 12, 2026
Merged

Fix issue when reading composite packages #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/io/mvnpm/esbuild/install/WebDepsInstaller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ public static boolean install(Path nodeModulesDir, List<WebDependency> dependenc
final String packageName = nameAndRoot.getKey();
final Path source = nameAndRoot.getValue();
final Path target = nodeModulesDir.resolve(packageName);
if (!Files.isDirectory(source)) {
LOG.debugf("ignored package ''%s'' probably installed through another package.json", packageName);
continue;
}
dirs.add(packageName);
PathUtils.deleteRecursive(target);
Files.createDirectories(target.getParent());
Expand Down
7 changes: 6 additions & 1 deletion core/src/main/java/io/mvnpm/esbuild/util/JarInspector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ private static Map<String, Path> findPackageNameAndRootWithPackage(Path root, bo
List<Path> foundFiles = searchFiles(root, PACKAGE_JSON, shouldDoMultiple);
for (Path path : foundFiles) {
String packageName = readPackageName(path);
paths.putIfAbsent(packageName, path.getParent());
if (packageName != null) {
paths.putIfAbsent(packageName, path.getParent());
}
}

return paths;
Expand Down Expand Up @@ -187,6 +189,9 @@ private static String readPackageName(Properties properties) {
private static String readPackageName(Path path) {
try {
JsonNode object = objectMapper.readTree(path.toFile());
if (!object.has("name")) {
return null;
}
return object.get("name").asText();
} catch (IOException ex) {
throw new UncheckedIOException(ex);
Expand Down