Skip to content

Commit

Permalink
Fix failing extension check tests (#1313)
Browse files Browse the repository at this point in the history
* ci: Allow extension check tests to fail

* To debug the issue causing failures

Signed-off-by: Mahendra Paipuri <[email protected]>

* ci: Set locale manually before browser check tests

* Ref: jupyterlab/jupyterlab#17079

Signed-off-by: Mahendra Paipuri <[email protected]>

* ci: Temporary fix to browser check test failure

Signed-off-by: Mahendra Paipuri <[email protected]>

* ci: Fix browser checks on conda tests too

Signed-off-by: Mahendra Paipuri <[email protected]>

* Remove the LANG variable
since it is not needed anymore

#1297 (comment)

---------

Signed-off-by: Mahendra Paipuri <[email protected]>
Co-authored-by: Mahendra Paipuri <[email protected]>
  • Loading branch information
mwouts and mahendrapaipuri authored Feb 9, 2025
1 parent b3c8c50 commit 5e6cda4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/step_tests-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ jobs:
jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "jupyterlab-jupytext.*OK"
# Commented out on Dec 15, 2024, until we can fix that test
# python -m jupyterlab.browser_check
python -m jupyterlab.browser_check
- name: Upload coverage
uses: codecov/codecov-action@v3
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/step_tests-pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,7 @@ jobs:
jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "jupyterlab-jupytext.*OK"
# Commented out on Dec 15, 2024, until we can fix that test
# python -m jupyterlab.browser_check
python -m jupyterlab.browser_check
- name: Upload coverage
uses: codecov/codecov-action@v3
Expand Down

0 comments on commit 5e6cda4

Please sign in to comment.