This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Add pipfile for pipenv, add count and json options #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr
suggested changes
May 26, 2020
Owner
mxr
left a comment
mxr
left a comment
There was a problem hiding this comment.
Thanks for the PR! Had no idea this was opened, sorry I missed the notification...
| @@ -0,0 +1,21 @@ | |||
| [[source]] | |||
Owner
There was a problem hiding this comment.
I updated the dependencies in #18 - let's undo the pipenv changes please
Comment on lines
+38
to
+40
| if args.count < 1: | ||
| print("Count cannot be < 1. Your input: {}".format(args.count)) | ||
| return |
Owner
There was a problem hiding this comment.
This should be validated with the type= arg instead
Comment on lines
+42
to
+45
| object_ids = [gen_random_object_id() for _ in range(args.count)] | ||
|
|
||
| if args.long_form: | ||
| print('ObjectId("{}")'.format(object_id)) | ||
| object_ids = ['ObjectId("{}")'.format(object_id) for object_id in object_ids] |
Owner
There was a problem hiding this comment.
The function was structured to avoid reassigning object_ids, so let's preserve that
| print(json.dumps(object_ids, indent=" ")) | ||
| else: | ||
| print(object_id) | ||
| [print(object_id) for object_id in object_ids] |
Owner
There was a problem hiding this comment.
This is using a list-comprehension solely to execute a side effect in a loop. Let's write an explicit loop instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of features I needed: create ObjectIDs in batch, and also output them in json format.