[claude] Fail a download that didn't sync instead of keeping an empty project - #26
Open
myieye wants to merge 1 commit into
Open
[claude] Fail a download that didn't sync instead of keeping an empty project#26myieye wants to merge 1 commit into
myieye wants to merge 1 commit into
Conversation
ExecuteSync reports an unreachable server as an unsynced result rather than throwing, so a download that got nothing still finished as a success and left a project claiming it synced with no data in it (sillsdev#2292). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
Staging PR — never merge; promoted to sillsdev when polished (see FORK.md).
ExecuteSyncreports an unreachable server as an unsynced result rather than throwing, soCreateProjectfinished happily and left a project that claims it synced and holds nothing — the state described in sillsdev#2292. Now it fails, andCreateProjectcleans the project up as it does for any other download failure.Salvaged from #25 (automatic retry), which is closed: retrying is a band-aid for a download that isn't resumable, and the user can already start one again.