feat(_mapdata): use top-level values for map.jinja dump files
#284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rubocop` already fixed during the previous PR (#283): * saltstack-formulas/php-formula#221
Also use Black-inspired Jinja formatting for the `init.sls`.
Provide a full breakdown of the method used to prepare the comparison between both files.
myii
added a commit
to myii/openntpd-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/openssh-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/openvpn-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/sudoers-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/rabbitmq-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/php-formula
that referenced
this pull request
Dec 23, 2020
`rubocop` violations fixed in 1a4d208. * Automated using myii/ssf-formula#284
myii
added a commit
to myii/php-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
Merged
19 tasks
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
myii
added a commit
to myii/template-formula
that referenced
this pull request
Dec 23, 2020
* Semi-automated using myii/ssf-formula#284
|
🎉 This PR is included in version 1.236.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
map.jinjaverification #281, feat(rabbitmq): managemap.jinjaverification #282 & feat(php): managemap.jinjaverification #283) were setting up verification files without a top-level key.map.jinjaformula (openssh) did have multiple top-level keys.valuestop-level key.rubocoplinter topre-commitrubocopalready fixed during the previous PR (feat(php): managemap.jinjaverification #283):map.jinjadump using_mapdatastate saltstack-formulas/php-formula#221inspecgem in the hope that the diff would work but still didn't -- the issue is diffing itself, not that it was previously a YAML comparison.