add image slide show update#15
Open
itsASpicyMeatball wants to merge 2 commits into
Open
Conversation
|
consider this @mykle1 |
|
Hi! Thanks for the code, it worked great. I decided to improve this by adding more functionality. In my PR #17 MagicMirror selectes a random image from list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR i've added code that will allow the module to be a slide show. I've done this by turning the ownImagePath configuration into an array and added a new configuration value of currentImg that defaults to a values of 0. I've also update the code to clear the interval if it's not being used aka there is no slide show. Last thing is updating the code to remove redundancies.