-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/song service #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myndaaa
wants to merge
30
commits into
dev
Choose a base branch
from
feature/song-service
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing history but not deleting it
- genre search is case insensitive - genre name taken check is case insensitive - no redundant double GET endpoints for genre, only one get endpoint to get all and get via query param. - Get endpoint allows close matches - fixed redundant and useless usage of /admin endpoints to : no deletion option for genre, only disable option., admin see all genre others only active ones - single db call for genre create, removed prechecks and returning exception error based on crud returns
…as {name} in endpoints which might have whitespaces.
- added fuzzy search to song.
- rmeoved /search endpoint in song and resuing current get endpoint with query params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSTasongentity.albumandalbumsongdata models crud functions and endpoints.backend/app/crud/artist.pyandbackend/app/schemas/artist.pyfor consistency with album/song usage.mutagenlibrary to extract audio metadataLogic Implemented:
/stream/song/{song_id}checks database for song existence, validates file exists on disk, then handles HTTP Range headers for seeking, parses "bytes=start-end" format and validates range bounds, then seeks to start position in file & reads only requested chunk [returns 206 Partial Content]