Conversation
available/README.md
Outdated
|
|
||
| Due to the restrictions of run-parts (only letters, numbers, dashes and underscores are permitted), domains in the filenames needs to have the periods replaced with dashes. For example, 'google.co.uk' would be 'google-co-uk' in the filename. | ||
|
|
||
| Use it by creating a symlink with the name `ifdomain_{domain}_{hook to run}`. The hook you want to run must exist in the same directory as the `ifdomain_` script your symlink points to. For example, `ifdomain_google-co-uk_reload_nginx` will call the `reload_nginx` hook if the domain is 'google.co.uk'. (Note that this means you need to create a symlink, in the same place as `ifdomain_` is, called `reload_nginx` pointing to `reload_`, if you want to use that). |
There was a problem hiding this comment.
If I'm reading this correctly, the symlink would need to be in the available directory, unless the user has rearranged things? Might be worth clarifying that, or perhaps list the necessary links for an example, like this:
deploy-cert/ifdomain_example-com_reload_nginx => ../available/ifdomain_
available/reload_nginx => reload_
There was a problem hiding this comment.
Firstly, thank you for the thorough review I appreciate your time and effort.
Please can you review the wording in 8b0c67c to see if that clarifies it? I added a simpler example and then the more complex chained-chain hook example, with the list of hook scripts and links as you suggested.
Hope that meets with your approval?
Thanks again,
Laurence
Co-authored-by: pdw-mb <pdw@mythic-beasts.com>
Co-authored-by: pdw-mb <pdw@mythic-beasts.com>
Co-authored-by: pdw-mb <pdw@mythic-beasts.com>
|
@pdw-mb this is ready for you to re-review, at your convenience. |
|
Hi guys, I've brought my fork up to date with current master. Can we re-review, I think I've addressed everything that was raised? (Still keen to get this merged :) ) Cheers, Laurence |
3 participants
Add hooks that selectively run other hooks based on the domain triggering the hook, interact with HP iLO out-of-band management to generate and upload certificates to them, and restart individual services.
Please do not merge until after #12 and #11 as this branch incorporates those fixes because they are required for: