-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Upgrade to hyper 1.0 #1858
Conversation
This upgrades our direct use of hyper to version 1.0 of the crate.
"hyper", | ||
"http 0.2.11", | ||
"http-body 0.4.5", | ||
"hyper 0.14.27", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this means we have a variety of hyper
versions now, increasing our dependency graph :/ have you checked how many crates we depend on/that need upgrading until we are back to one version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reqwest and igd for released bits.
console-subscriber -> tonic -> axum for dev dependencies. axum already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed sbstp/rust-igd#58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reqwest: seanmonstar/reqwest#2039
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tonic: hyperium/tonic#1579
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it will be a while until those libs upgrade :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i created #1863 to not lose those links
## Description This upgrades our direct use of hyper to version 1.0 of the crate. ## Notes & open questions This is adds a little duplication to our deps for now since reqwest is still using hyper 1.0. ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant.
Description
This upgrades our direct use of hyper to version 1.0 of the crate.
Notes & open questions
This is adds a little duplication to our deps for now since reqwest is still
using hyper 1.0.
Change checklist