Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to hyper 1.0 #1858

Merged
merged 6 commits into from
Dec 5, 2023
Merged

refactor: Upgrade to hyper 1.0 #1858

merged 6 commits into from
Dec 5, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Dec 1, 2023

Description

This upgrades our direct use of hyper to version 1.0 of the crate.

Notes & open questions

This is adds a little duplication to our deps for now since reqwest is still
using hyper 1.0.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

flub added 3 commits December 1, 2023 17:33
This upgrades our direct use of hyper to version 1.0 of the crate.
@flub flub marked this pull request as ready for review December 4, 2023 16:16
@flub flub requested review from ramfox and dignifiedquire December 4, 2023 16:17
"hyper",
"http 0.2.11",
"http-body 0.4.5",
"hyper 0.14.27",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we have a variety of hyper versions now, increasing our dependency graph :/ have you checked how many crates we depend on/that need upgrading until we are back to one version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reqwest and igd for released bits.

console-subscriber -> tonic -> axum for dev dependencies. axum already exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it will be a while until those libs upgrade :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i created #1863 to not lose those links

@flub flub requested a review from dignifiedquire December 5, 2023 12:53
@flub flub added this pull request to the merge queue Dec 5, 2023
Merged via the queue into main with commit b8aa5d6 Dec 5, 2023
@flub flub deleted the flub/hyper-1 branch December 7, 2023 09:37
matheus23 pushed a commit that referenced this pull request Nov 14, 2024
## Description

This upgrades our direct use of hyper to version 1.0 of the crate.

## Notes & open questions

This is adds a little duplication to our deps for now since reqwest is
still
using hyper 1.0.

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants