-
Notifications
You must be signed in to change notification settings - Fork 317
feat: WIP allow non-ed keys in EndpointID #3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rklaehn
wants to merge
10
commits into
main
Choose a base branch
from
generic-endpoint-id-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still ugly .expect_ed() in tests.
flub
reviewed
Nov 13, 2025
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3653/docs/iroh/ Last updated: 2025-11-13T16:32:56Z |
174c70c to
e4549e5
Compare
11 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
…3662) ## Description This would make the diff smaller if we decide to go with generic endpoint ids. See #3653 . And I also think it is nicer in any case. ## Breaking Changes None ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist <!-- Remove any that are not relevant. --> - [ ] Self-review. - [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - [ ] Tests if relevant. - [ ] All breaking changes documented. - [ ] List all breaking changes in the above "Breaking Changes" section. - [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are: - [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc) - [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip) - [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs) - [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe) - [ ] [`sendme`](https://github.com/n0-computer/sendme)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the latest attempt that leaves more internals alone.
Replaces #3576
The basic approach is to first replace the EndpointId type alias with PublicKey everywhere and then reintroduce EndpointId as a new type only in public APIs. The entire relay crate, despite being public, still works with PublicKey.
Every place where we have a PublicKey and need an EndpointId on the outside we can just use .into(). In tests it is Ok to go from EndpointId to PublicKey using .expect_ed().
Discovery works with EndpointId, but discovery services that fundamentally require ed keys, such as pkarr, will just do nothing for non ed keys.
Todo:
Todo (later?):
The relay protocol of course remains fully based on ed keys. Changing that to support different keys would be a major effort, but with multipath we might be able to just add a second one using whatever new keys we support.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme