feat(multipath): add back basic metrics #3672
Conversation
| pub send_relay_error: Counter, | ||
|
|
||
| // Data packets (non-disco) | ||
| pub send_data: Counter, |
There was a problem hiding this comment.
This was unused, and it would be just the sum of send_ipv4, send_ipv6, send_relay, so I removed it because the sum can be calculated client-side.
|
|
||
| // Data packets (non-disco) | ||
| pub send_data: Counter, | ||
| pub send_data_network_down: Counter, |
There was a problem hiding this comment.
This was unused, not sure if we'd want this back?
| pub actor_tick_other: Counter, | ||
|
|
||
| /// Number of endpoints we have attempted to contact. | ||
| pub endpoints_contacted: Counter, |
There was a problem hiding this comment.
I don't think we ever could do this in a good way, because we don't keep lists of endpoint ids over restarts, so this was already a bad metric for a while - removed it.
| /// Number of endpoints we have attempted to contact. | ||
| pub endpoints_contacted: Counter, | ||
| /// Number of endpoints we have managed to contact directly. | ||
| pub endpoints_contacted_directly: Counter, |
There was a problem hiding this comment.
same as above, I don't think there's a good way to do it meaningfully.
| /// Number of connections with a successful handshake. | ||
| pub connection_handshake_success: Counter, | ||
| /// Number of connections with a successful handshake that became direct. | ||
| pub connection_became_direct: Counter, |
There was a problem hiding this comment.
These two are better handled by the new conn_ metrics above
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3672/docs/iroh/ Last updated: 2025-11-18T10:45:36Z |
Description
This adds back basic metrics to
feat-multipath.conn_metrics (they were all currently unused onfeat-multipath) into something meaningful:conn_became_directmetric we had previously. "Direct" connections areconn_open-conn_relay_only.Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme