This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
A fix and a couple of improvements #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 4, 2016 19:40
…, which would make Readabilty.js crash. Proactively encoding the url guards from this to happen.
…rection. This is a fix to the problem, given that the direction css property is defined at the body tag level of a document.
…rvice would probably be the only part that sees the original HTML document. So it is important to read some crucial meta-data here. In my case I need to know the document's language.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, I described the motivations in the commits. I'm not sure if it's a good idea to send all three commits in one pull request, I just don't know how to do this right way. Hopefully, they can be cherry picked if you will not find all of them useful.