feat: backend selector (--backend fd / rg-files) + fix platform-neutral path comparison#60
Open
lyra-explorer wants to merge 4 commits into
Open
feat: backend selector (--backend fd / rg-files) + fix platform-neutral path comparison#60lyra-explorer wants to merge 4 commits into
lyra-explorer wants to merge 4 commits into
Conversation
Refs na-navi#55 Adds --backend choices for everything, fd, and rg-files, resolves the default backend with Windows-first behavior, and routes search execution through a backend dispatch layer. Windows default remains Everything/es.exe. Non-Windows requires explicit --backend fd or --backend rg-files. Stats, JSON output, and search logs now include the selected backend name.
Refs na-navi#55 Adds focused backend tests for default resolution, missing backend errors, dispatch to existing Everything functions, fd/rg-files command construction, timeout handling, and backend fields in stats/JSON/log output.
Refs na-navi#55 Documents explicit backend selection, clarifies search JSON output and backend stats, and adds Compatibility Notes guidance for backend-related PRs.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: backend selector (
feat/backend-selectorbranch, 3 commits)--backend fd/--backend rg-filesfor non-Windows platformsresolve_backend(): Windows defaults toeverything, others require explicit--backendbackend_search()dispatches to the selected backend with timeout/budget support--check --jsonand search stats/logs now includebackendfieldtests/test_backend.py: 16 tests covering resolve, dispatch, timeout, observationfix: platform-neutral
_is_under_root()(1 commit)_is_under_root()now selectsntpathorposixpathsemantics from the input path shape, not the host OSos.path.commonpath()follows the host OS path semanticsenforce_allowed/filter_resultsnow work correctly with Windows paths on any OSTest results
All previously failing
test_cli.pytests (5 failures) now pass alongside alltest_backend.pytests.Verified cases
C:\Users\test\file.txtunderC:\Users\testTruec:\USERS\test\file.txtunderC:\users\test(case-insensitive)TrueC:\root\file.txtunderC:\rootTrueC:\root2\file.txtunderC:\root(sibling prefix)FalseD:\root\file.txtunderC:\root(different drive)False/home/claw/doc.txtunder/home/claw(POSIX)True/home/claw2/doc.txtunder/home/claw(POSIX sibling)FalseNotes
se querybehavior is unchanged — Everything / es.exe remains the default backend--backend-selected paths are explicit opt-in per CONTRIBUTING.md guidelines