Skip to content

Update to CometBFT v0.38 #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update to CometBFT v0.38 #436

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce6c980
Updates events fetching for CometBFT v0.38
grarco Oct 9, 2025
d7320c4
Changes end events fetching to be backward-compatible
grarco Oct 9, 2025
6ed51cf
Fixes typo
grarco Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 24 additions & 32 deletions shared/src/block_result.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,47 +412,39 @@ impl TxAttributesType {

impl From<TendermintBlockResultResponse> for BlockResult {
fn from(value: TendermintBlockResultResponse) -> Self {
fn cast_event(event: &tendermint::abci::Event) -> Event {
let kind = EventKind::from(&event.kind);
let raw_attributes = event.attributes.iter().fold(
BTreeMap::default(),
|mut acc, attribute| {
acc.insert(
String::from(attribute.key_str().unwrap()),
String::from(attribute.value_str().unwrap()),
);
acc
},
);
let attributes =
TxAttributesType::deserialize(&kind, &raw_attributes);
Event { kind, attributes }
}

let begin_events = value
.begin_block_events
.unwrap_or_default()
.iter()
.map(|event| {
let kind = EventKind::from(&event.kind);
let raw_attributes = event.attributes.iter().fold(
BTreeMap::default(),
|mut acc, attribute| {
acc.insert(
String::from(attribute.key_str().unwrap()),
String::from(attribute.value_str().unwrap()),
);
acc
},
);
let attributes =
TxAttributesType::deserialize(&kind, &raw_attributes);
Event { kind, attributes }
})
.map(cast_event)
.collect::<Vec<Event>>();
// NOTE: starting with comet v0.38, end events are only available from
// the `finalize_block_events` field. For backward-compatibility
// reasons we still evaluate `end_block_events` as well and merge the
// two outputs
let end_events = value
.end_block_events
.unwrap_or_default()
.iter()
.map(|event| {
let kind = EventKind::from(&event.kind);
let raw_attributes = event.attributes.iter().fold(
BTreeMap::default(),
|mut acc, attribute| {
acc.insert(
String::from(attribute.key_str().unwrap()),
String::from(attribute.value_str().unwrap()),
);
acc
},
);
let attributes =
TxAttributesType::deserialize(&kind, &raw_attributes);
Event { kind, attributes }
})
.map(cast_event)
.chain(value.finalize_block_events.iter().map(cast_event))
.collect::<Vec<Event>>();
Self {
height: value.height.value(),
Expand Down