chore: add masp funcs from outstanding PR #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neocybereth
changed the title
jurevans
reviewed
Aug 22, 2025
| pub fn to_viewing_key(&self) -> Result<ExtendedViewingKey, String> { | ||
| let xfvk = self.0.to_viewing_key(); | ||
| Ok(ExtendedViewingKey(NamadaExtendedViewingKey::from(xfvk))) | ||
| } |
There was a problem hiding this comment.
Nice! Quick note: Since we don't have an automated process to bump versions yet (there's an issue to add this!) there are a few things we need to do before we can publish:
- Bump all
package.jsonversions from0.20.7to0.20.8 - Bump
packages/libversion as well - you can manually changelib/src/version.ts, but it is also automatically updated when you build any of the SDKs - Since this will produce changes in the API for
PseudoExtendedKey, after rebuilding the wasm locally, we should regenerate the type docs (https://github.com/namada-net/namada-sdkjs/blob/main/docs/classes/PseudoExtendedKey.md) so these functions get picked up (yarn build:docs). Then it's just a matter of building and publishing all 3 SDK variants (also should be automated).
Most (if not all) of this should be automated soon! :D
There was a problem hiding this comment.
Thank you for the instructions!
I did all of the above and commited here.
Looks like it changed 58 files just FYI, dk if that's expected so just want to raise awareness.
There was a problem hiding this comment.
That's entirely expected :D Really generating type docs is a pre-release task, we just need to set that all up still. It's annoying to have to remember all of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in MASP funcs from namada-net/namada-interface#2280