Skip to content

week 1 assigment#1

Open
namankhandelwalintimetec wants to merge 4 commits intomainfrom
html-css
Open

week 1 assigment#1
namankhandelwalintimetec wants to merge 4 commits intomainfrom
html-css

Conversation

@namankhandelwalintimetec
Copy link
Owner

No description provided.

home.css Outdated
@@ -0,0 +1,226 @@
body{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make proper indentation

home.css Outdated
}


.imge {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be "image"

home.css Outdated
list-style-type: none;
/* Remove bullets */
padding: 0;
/* Remove padding */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comments

home.css Outdated
}


.conatiner1{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use 1 or 2 in names.
Instead give some proper names.

home.css Outdated
height: 50px;
}

.sideimage{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give css class and ids names in kebab case. Like "image-container".

Please make changes at all places in css files

home.html Outdated
<link rel="stylesheet" href="home.css">
</head>

<body>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give proper & consistent indentation in all files.

home.html Outdated
</nav>


<div class="conatiner1">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add 1 or 2 in naming. Instead please specify proper names. Like "main-container", "body-container" etc.

home.html Outdated

<div class="conatiner1">
<div class="center">
<P class="paragraph">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why P is capital ? Please correct

home.html Outdated
<h3 class="color3">Happy Independent Day</h3>
<p class="color3">Lorem ipsum dolor sit amet, consectetur adipisicing elit. Et modi nihil cumque
consectetur voluptatum harum explicabo at facilis similique libero, earum,
<br />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use br tag for new line as its not a good practice. Use css.

home.html Outdated
</div>
</div>

<div class="createflex">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give proper naming. createflex is not a good name.

And, for all class and ids name use kebab case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants