Modify linter to run on nearest go module root #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found this PR only after opening #67 and after implementing it myself in https://github.com/yeldiRium/golangci-lint-langserver/tree/feat/monorepo-support and based on that have some input: golangci-lint searches for the closets go.mod itself. there seems to be no need to implement this. golangci-lint-langserver can run golangci-lint in the directory of each file and golangci-lint will recognize the closest go.mod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the lint function to recursively search upwards from the current file's directory for the nearest go.mod file, then runs golangci-lint on that module root instead of the immediate file directory.
This PR fixes linting issues in monorepos where the workspace root lacks a go.mod file.