383737 - Make moves require a MovesProjectStep #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-brousse
force-pushed
the
383737-make-moves-require-a-moves_project_step
branch
from
0c7b276 to
51f202d
Compare
B-Rass
approved these changes
May 28, 2025
B-Rass
requested changes
May 28, 2025
There was a problem hiding this comment.
L'affichage de la baie ne fonctionne pas quand on créé un déplacement.
J'ai l'erreur suivante dans les logs :
web | ActiveRecord::RecordNotFound (Couldn't find Server without an ID):
web |
web | app/controllers/moves_controller.rb:92:in 'MovesController#load_server'
web | config/initializers/fix_headers_middleware.rb:12:in 'FixHeadersMiddleware#call'
B-Rass
reviewed
May 28, 2025
config/routes.rb
Outdated
| get :load_connection | ||
| get "/frames/:frame_id", to: "moves#frame", as: :frame | ||
| get "/print/:frame_id", to: "moves#print", as: :print | ||
| match 'update_connection', to: 'moves#update_connection', via: %i[patch post put] |
There was a problem hiding this comment.
Suggested change
| match 'update_connection', to: 'moves#update_connection', via: %i[patch post put] | |
| match "update_connection", to: "moves#update_connection", via: %i[patch post put] |
B-Rass
reviewed
May 28, 2025
app/views/moves/_form.html.erb
Outdated
| @@ -121,7 +122,7 @@ function select_frame(frame_id, view){ | |||
| console.log("Selected frame : " + JSON.stringify(frame_id)); | |||
| $.ajax({ | |||
| method: "GET", | |||
| url: "<%= load_frame_moves_path %>", | |||
| url: "<%= load_server_moves_project_step_moves_path(moves_project_step) %>", | |||
There was a problem hiding this comment.
Suggested change
| url: "<%= load_server_moves_project_step_moves_path(moves_project_step) %>", | |
| url: "<%= load_frame_moves_project_step_moves_path(moves_project_step) %>", |
Not sure to understand how to reproduce this |
B-Rass
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.