Initial setup for concurrent workers #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianbgt
reviewed
Dec 9, 2024
packages/cli/src/api/split.ts
Outdated
| .catch((error) => { | ||
| console.error(error); | ||
| throw error; | ||
| }); |
There was a problem hiding this comment.
The response is sent before the worker or done with the jobs.
Should wait until the worker are done before sending the response
There was a problem hiding this comment.
Updated the code to wait for the response 🟢
florianbgt
reviewed
Dec 9, 2024
| import Parser from "tree-sitter"; | ||
| import assert from "assert"; | ||
| import { getLanguagePlugin } from "../languagesPlugins"; | ||
| import { DepExport } from "../languagesPlugins/types"; | ||
|
|
||
| class SplitRunner { |
There was a problem hiding this comment.
Let's delete this class, become kind of useless now. We can do a simple method to replace it.
Maybe in another PR
florianbgt
reviewed
Dec 9, 2024
|
|
||
| console.time("Remove errors"); | ||
| removeErrors(); | ||
| console.timeEnd("Remove errors"); |
There was a problem hiding this comment.
Need to find a better way to log. Maybe with a fancier logger. Cause here since they now run in parallel, very hard to read the logs. Also probably in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR refactors the split functionality to leverage Node.js Worker Threads, enabling concurrent processing. Previously, the splitting operations ran sequentially, which could be time-consuming for larger projects and multiple endpoints. By introducing parallelization with worker threads, we significantly improve the speed and efficiency of the process.
Related Issue
Issue Number: #41
Notes for Reviewer:
@florianbgt We'll not have to worry about thread count and stuff since worker_threads handles everything automatically pretty well and doesn't cause leaks. We can add an extra layer of checking on that but rather to have that in a separate PR to not block this since it's a good improvement already.
Checklist