get_info: zero-initialize numeric return value #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
approved these changes
Aug 20, 2024
Great - thank you! Let me know if you think the |
|
I don't think it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team:
I was thinking about possible low-touch approaches to resolving the issue highlighted in #398. One way to do that, I think, is whenever a user retrieves an
InfoTypereturning a numeric value, we should advise them that they should consider using theuint64_tflavor ofget_info.To make that possible, we need to zero-initialize the return value to make sure that any over-allocated bits are unset; Both on x86/debian/gcc11 as well as x86/macos/clang15 the updated unit test fails highlighting the issue.
Thanks!