Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev to Master #412

Merged
merged 98 commits into from
Mar 12, 2025
Merged

Dev to Master #412

merged 98 commits into from
Mar 12, 2025

Conversation

vhaasteren
Copy link
Member

There have been quite a few updates again. Most significantly, no more dependency on libstempo and PINT, which will help with dependency-hell for other packages.

Changes:

  • Adding hypercube transformations and PPF functions
  • Support for feather files
  • Removal of libstempo and PINT as mandatory dependencies
  • Bugfix: allow 2D left / right arrays in MarginalizingNmat
  • Updated examples

astrolamb and others added 30 commits November 30, 2023 15:40
@astrolamb
adding hypercube transform and test
e6f1e4c
@blarsen10
Get TM processes from ConditionalGP
cb3e25e
@astrolamb
Merge branch 'nanograv:master' into ppf_hypercube
85cc6b2
@astrolamb
Merge branch 'nanograv:master' into main
67fe74d
@astrolamb
Merge remote-tracking branch 'origin/main' into ppf_hypercube
f151d46
@astrolamb
Merge remote-tracking branch 'upstream/dev' into ppf_hypercube
c66eaa0
@astrolamb
Merge branch 'ppf_hypercube' of github.com:astrolamb/enterprise into …
4a15d3c 
…ppf_hypercube
@blarsen10
fix for tempo2 pulsars if fitpars is an array
9cc953d
@AaronDJohnson
add feather files and remove pint/libstempo
9a1a9c2
@AaronDJohnson
remove to_pickle test, add to_feather test
e996aef
@AaronDJohnson
Merge branch 'dev' into feather_files
ef37702
@AaronDJohnson
reformat with black
d047b59
@AaronDJohnson
reformat with OLDER VERSION of black
a573638
@AaronDJohnson
Merge remote-tracking branch 'upstream/master' into feather_files
22706d7
@astrolamb
Merge branch 'nanograv:master' into ppf_hypercube
31f13c1
@AaronDJohnson
add feather data files for tests
6171575
@JacobCT
Added elif statement made by Kathrin Grunthal that is needed for Fe c…
24ef67e 
…alculation and OS statistics. We changed her original elif-condition from: elif right.ndim == 2 and left_array is not None and left_array.ndim == 2:, to: elif left_array is not None and right.ndim == left_array.ndim and right.ndim<=2:. This was done in order to include the case where both right and left_array have dimension 1, but they are not the same.
@JacobCT
Linted the code using Black.
f8ee6df
@AaronDJohnson
default to feather in tests, skip t2 and pint
6174a80
@AaronDJohnson
lint
f2e7065
@AaronDJohnson
update tests with data, skip t2 pint tests
1847506
@AaronDJohnson
lint issue and remove libstempo install from CI
d83a97b
@AaronDJohnson
uncomment some tests
dba9c0e
@AaronDJohnson
UPDATE A SINGLE SPACE, NICE FIND LINTER
a702e0e
@AaronDJohnson
only import if PINT is installed
39bda59
@AaronDJohnson
make 1909 reappear
6752e75
@AaronDJohnson
avoid testing wideband on feather files right now
8ae71e8
@AaronDJohnson
loosen tolerance by 1 OoM
ff8ba50
@AaronDJohnson
remove codecov for tempo2/pint segments of Pulsar
0c8e867
@AaronDJohnson
does this change codecov?
fbf1bad
AaronDJohnson and others added 23 commits January 8, 2025 16:44
@AaronDJohnson @astrolamb
loosen tolerance by 1 OoM
cd2b166
@AaronDJohnson @astrolamb
remove codecov for tempo2/pint segments of Pulsar
c826a07
@AaronDJohnson @astrolamb
does this change codecov?
2a43161
@AaronDJohnson @astrolamb
fix spacing
a428323
@AaronDJohnson @astrolamb
lower required codecov to 70%
55b4024
@AaronDJohnson @astrolamb
one more time...
a43c603
@AaronDJohnson @astrolamb
temporarily loosen codecov threshold
4187943
@AaronDJohnson @astrolamb
allow some metadata to not be set
26fd876
@AaronDJohnson @astrolamb
add flags as U-type ndarrays
5d23b15
@JacobCT @astrolamb
Added elif statement made by Kathrin Grunthal that is needed for Fe c…
ffe8d8e 
…alculation and OS statistics. We changed her original elif-condition from: elif right.ndim == 2 and left_array is not None and left_array.ndim == 2:, to: elif left_array is not None and right.ndim == left_array.ndim and right.ndim<=2:. This was done in order to include the case where both right and left_array have dimension 1, but they are not the same.
@JacobCT @astrolamb
Linted the code using Black.
efecbcb
@JacobCT @astrolamb
Added unit tests for MarginalizingNmat() in gp_signals.py
e2e3ab3
@AaronDJohnson @astrolamb
lint files
e5f6f56
@AaronDJohnson @astrolamb
more linting
d20ce36
@AaronDJohnson @astrolamb
try with an older version of black
7a25628
@AaronDJohnson @astrolamb
lint
2fc1313
@AaronDJohnson @astrolamb
lint again
c02ec85
@AaronDJohnson @astrolamb
temporarily increase % on codecov patch
8ac49c1
@AaronDJohnson @astrolamb
add usage example in usage.ipynb
23d908c
@blarsen10 @astrolamb
flake8
d12c1af
@astrolamb
Merge branch 'dev' into ppf_hypercube
399b667
@astrolamb
linting
dfe99d1
@vhaasteren
Merge pull request #389 from astrolamb/ppf_hypercube
8676577 
PPF hypercube
@vhaasteren vhaasteren requested a review from AaronDJohnson March 5, 2025 15:30
AaronDJohnson
AaronDJohnson requested changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@AaronDJohnson AaronDJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one section that could use a little cleaning for maintainability. If we want to do it later, I will submit an issue instead.

@AaronDJohnson
Copy link
Collaborator

The rule sets have been changed to accept mac-os latest, so if we rerun the CI, we should be able to merge.

@vhaasteren vhaasteren merged commit 40060b1 into master Mar 12, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronDJohnson AaronDJohnson AaronDJohnson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vhaasteren @AaronDJohnson @astrolamb @blarsen10 @JacobCT