Modernize type annotation to use builtins #883
Conversation
github-actions
bot
added
the
documentation
|
|
||
| ```python | ||
| def napari_get_reader(path: Union[str, List[str]]) -> Optional[ReaderFunction] | ||
| def napari_get_reader(path: Union[str, list[str]]) -> Optional[ReaderFunction] |
There was a problem hiding this comment.
Does it make sense to change this? it's from the hook_spec, so that would be older napari and older python, right? So maybe we should leave them to match the original code?
I'm not sure anyone is still migrating anything, so it might be moot...
| ```python | ||
| def napari_get_writer( | ||
| path: str, layer_types: List[str] | ||
| path: str, layer_types: list[str] |
There was a problem hiding this comment.
Same comment as above, maybe we should leave this since it's from an era when List was the correct type hint.
| def writer( | ||
| path: str, layer_data: List[Tuple[Any, Dict, str]] | ||
| ) -> List[str] | ||
| path: str, layer_data: list[tuple[Any, dict, str]] |
|
Not a blocker at all, but maybe we shouldn't change the hook_spec code? It's from a different era and was correct at the time. Someone migrating -- though I doubt anyone is doing that now? -- would encounter that code. |
|
@psobolewskiPhD If you are at all concerned, perhaps the best thing would be to add a note to the doc that this applies to Python 3.9 and later. If someone wants to use 3.8 or earlier, they would need the older typing format. |
|
Eh. |
5 participants
References and relevant issues
Description
We should not suggest using
Listwhen all supported Python versions supportlist[].