Use npe2 adaptor when discovering plugins for the installed list

[DragaDoncila]

Prior to this PR, installing an npe1 plugin with Use npe2 adaptor turned on in napari didn't recognize it as a shimmed plugin. As a result, it didn't ask the user to restart (even though a restart is needed to load the plugin), and didn't display the npe2 (adapted) badge.

This PR updates the manager to read the state of the setting and use it appropriately.

To test that this PR works:

1. Install napari from main, launch a viewer
2. Turn on Use npe2 adaptor in Preferences. Restart napari (skip this if you already had the setting turned on)
3. Open the plugin manager using Install/Uninstall plugins
4. Install an npe1 plugin e.g. Label-Creator or anything off this list
5. ❌ Plugin installs, you're not told to restart, the plugin doesn't get the (npe1) adapted label, the plugin widget is not listed in Plugins
6. (Optional) Restart napari, plugin gets the (npe1) adapted label, plugin widget is listed in Plugins
7. Uninstall your plugin
8. Install napari-plugin-manager from this branch
9. Launch a viewer, install your plugin again
10. ✔️ You're told to restart, plugin gets (npe1) adapted label, and upon restarting, your widget is listed

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (3da07a3) to head (ad7d541).

Files with missing lines	Patch %	Lines
src/napari_plugin_manager/qt_plugin_dialog.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files          13       13           
  Lines        2107     2109    +2     
=======================================
+ Hits         2001     2003    +2     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DragaDoncila]

@Czaki I tried looking at ways to test this PR but I can't quite understand whether the current tests are actually covering the showing of the restart message or not. I think they're not... It would be awesome if you could take a look at this and see how I might add a test for this behaviour...

I want to test that when an npe1 plugin is installed with Use npe2 adaptor turned on, the show_message function is called. So, this line here. I've confirmed it works visually.

[Czaki]

No it is not covered

[Czaki]

I want to test that when an npe1 plugin is installed with Use npe2 adaptor turned on, the show_message function is called. So, this line here. I've confirmed it works visually.

you mean that it should be called when npe1 plugin is installed?

[DragaDoncila]

you mean that it should be called when npe1 plugin is installed?

Yes, the show_message function should be called when an npe1 plugin is installed and use_npe2_adaptor is True. I've confirmed visually that it works, but couldn't figure out a test

[DragaDoncila]

I don't understand why this is failing now 😭 all I did was merge main smh @Czaki any ideas...

[DragaDoncila]

Hmm I wonder if it's because we merged napari/#7627 in the meantime... Will take a look

[psobolewskiPhD]

Tests are broken currently because of changes in the python matrix.
See my PR for an approach to fixing them:
#140

(there may be other issues too of course!)

[DragaDoncila]

OK if this passes CI I think we should merge without tests, assuming a couple of people actually pull it down to try it.

If it fails I will try take a look at what the issue is, since it'll probs be related to the napari PR

[psobolewskiPhD]

All of the fails are with napari from the repo. All of the release (0.5.6) pass.
I suspect the warning from the napari PR is messing up the test in this repo.