-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin all criticall pacakages in plugin installer #139
base: main
Are you sure you want to change the base?
Conversation
@psobolewskiPhD please see this as an alternative to #138. |
CRITICAL_PACKAGES_PIN_CONDA = [ | ||
f"{pkg}={parse_version(package_version(pkg)).base_version}" | ||
for pkg in CRITICAL_PACKAGES | ||
] # + QT_BACKENDS_PIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how to prevent installing additional backend on conda.
@Czaki yeah i dont see anything easy. i think there would need to be a Qtbackend virtual package. Edit: |
I think such an approach will be simpler to debug in bundled napari than "I have installed plugin and napari do not start" |
Bundled napari is a different beast IMO. |
I almost wonder if we should split this in two:
|
It may be a good idea. |
This is my proposition for pining of dependency.
Instead of adding lower/upper bound for packages, Pin all packages that are critical to napari (list is currently incomplete)
We may not know about problematic versions, and maybe we should not allow for that without using external tools for environment management