Skip to content

Conversation

@FloFriebel
Copy link

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

no related issues.
feature based on a dischord conversation

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@FBruzzesi FBruzzesi added the enhancement New feature or request label Nov 3, 2025
@MarcoGorelli
Copy link
Member

MarcoGorelli commented Nov 3, 2025

thanks for taking a look

there's some discussion in polars about the concat_list API, tbh I think what we're after is something like what they're describing as pl.list pola-rs/polars#8510

I think concat_list, as it's implemented in Polars, does too much at the moment and is too magical

So, I'd suggest:

  • as a precursor, let's try to get pl.list implemented in Polars
  • then, let's add nw.list

@FloFriebel
Copy link
Author

Thanks @MarcoGorelli , because that explains some of the doubts I did get yesterday looking at the output, again...

@FloFriebel
Copy link
Author

Shall I try to implement it in polars? Does anyone know how hard/easy would it be? Could I get some help on how to do that ?

Or is better to find myself another easy PR in narwhals?

@MarcoGorelli
Copy link
Member

Do you know Rust? If not, it may be too hard

@FloFriebel
Copy link
Author

Missing some Emojies there, no RUST-knowledge here πŸ˜….

@MarcoGorelli
Copy link
Member

Or is better to find myself another easy PR in narwhals?

If there's nothing in the issue tracker that looks tractable, I'd suggest trying to use Narwhals to build something, and when you come across something which:

  • isn't well-documented
  • is buggy
  • is missing

then that's your good first contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants