Skip to content

Conversation

@FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

It's not much

"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: Free Threading :: 2 - Beta",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not really testing anything in a free threading way. We mostly rely on underlying libraries to be compliant, but we don't have test for anything narwhals introduces

@MarcoGorelli
Copy link
Member

thanks - ok with the license, but i don't think we need to list all the python versions, in all likelihood any version of narwhals will be forwards-compatible with new versions of python

@FBruzzesi
Copy link
Member Author

thanks - ok with the license, but i don't think we need to list all the python versions, in all likelihood any version of narwhals will be forwards-compatible with new versions of python

I think it's nice to have, especially for versions that reached EOL. What should be assumed for a generic "Programming Language :: Python :: 3"? For instance, we still support 3.9 which is EOL, but in some time that will be no longer the case. It's very low effort to keep these in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants