-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #375, Separate network logic in pc-rtems to support generic targets #376
Draft
skliper
wants to merge
4
commits into
nasa:main
Choose a base branch
from
skliper:fix375-generic_rtems
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dmknutsen, @alanc98, @jphickey - another one for discussion if we want to go this route or if there are any better ideas |
ef155d4
to
20d6a15
Compare
20d6a15
to
5a38bcd
Compare
Note - discussed at 20230803 CCB, sounds like this is the right direction just need to separate so the PC specifics can be included in that case (source select) |
5a38bcd
to
ca9ff99
Compare
ca9ff99
to
f3bbe6b
Compare
f3bbe6b
to
5102e94
Compare
2718d39
to
65c3258
Compare
65c3258
to
4f2d699
Compare
2 tasks
fd39b8a
to
22fe181
Compare
22fe181
to
5521aea
Compare
5521aea
to
50dc9d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
NOTE: really this is just a draft proof of concept to show this can be used generically if the network config is removed
Testing performed
Spot checked with LEON3 QEMU.
Expected behavior changes
Eventually plan to use source selection to include platform specific config... or consider making this generic in some other way. PSP module would be nice but I'm not aware of a way to select from a toolchain file or based on platform without making another psp.
System(s) tested on
LEON3 QEMU, see nasa/osal#1350
Additional context
Depends on an as-yet submitted toolchain file.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC