Fix #443, Correct minor bugs + typos in the VxWorks layer #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbaker
reviewed
Apr 8, 2025
| int32 return_code; | ||
|
|
||
| if (RestartType != CFE_PSP_RST_TYPE_PROCESSOR) | ||
| if (RestartType == CFE_PSP_RST_TYPE_POWERON) |
There was a problem hiding this comment.
Hi @thnkslprpt, what was the rationale for changing this to check for equaling POWERON?
dzbaker
reviewed
Apr 8, 2025
dzbaker
added
the
CCB:Ready
|
CCB 10 April 2025: Decided to wait for response from @thnkslprpt and then approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
CFE_PSP_InitProcessorReservedMemory(always returnsCFE_PSP_SUCCESSanyway)OS_Application_StartupTesting performed
GitHub CI actions all passing successfully and confirmed locally that test coverage is unaffected.
Expected behavior changes
Logic unchanged other than fixes mentioned above.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt