Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #452, rtems sysmom overflow buffer #453

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Mar 31, 2025

Fix #452, rtems sysmom coverage test causes an buffer overflow.

Checklist (Please check before submitting)

Describe the contribution
A clear and concise description of what the contribution is.

  • Include explicitly what issue it addresses [e.g. Fixes #X]

Testing performed
Steps taken to test the contribution:

  1. Run against RTEMS

  2. Run unit test on linux

  3. Make ENABLE_UNIT_TESTS=true SIMULATION=native

  4. make install

  5. make test

  6. make lcov

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • API Change: xxx (if applicable)
  • Behavior Change: xxx (if applicable)
  • Or no impact to behavior

System(s) tested on

  • Hardware: [e.g. PC, SP0, MCP750]
  • OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
  • Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

  • Note CLAs apply to only software contributions.
    Anh Van, GSFC

@dzbaker
Copy link
Contributor

dzbaker commented Apr 3, 2025

CCB 3 April 2025: Provisionally approved pending rename of num_cpus variable.

Fix nasa#452, rtems sysmom coverage test causes an buffer overflow.
@avan989 avan989 force-pushed the Fix-452-rtems_sysmon_coverage_test_buffer_overflow branch from c335dbb to 23d7346 Compare April 7, 2025 11:36
@avan989
Copy link
Contributor Author

avan989 commented Apr 7, 2025

updated.

dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

*cFS*
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker mentioned this pull request Apr 7, 2025
2 tasks
@dzbaker dzbaker merged commit 9e34f5a into nasa:main Apr 7, 2025
10 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Apr 7, 2025
*Combines:*

cFE equuleus-rc1+dev243
osal equuleus-rc1+dev113
psp equuleus-rc1+dev67
sample_app equuleus-rc1+dev54

**Includes:**

*cFS*
- #834

*cFE*
- nasa/cFE#2646

*osal*
- nasa/osal#1497

*PSP*
- nasa/PSP#453

*sample_app*
- nasa/sample_app#238

Co-authored by:Kenji Brameld <[email protected]>
Co-authored by:Anh Van <[email protected]>
Co-authored by:Jose Martinez Pedraza <[email protected]>
@dzbaker dzbaker added CCB:Approved Indicates Approval by CCB and removed CCB: Provisionally-Approved labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rtems sysmon coverage test overflow buffer
2 participants