-
Notifications
You must be signed in to change notification settings - Fork 112
[nasa/nos3#624] Scenario stf rapid tumbling #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #691 +/- ##
==========================================
+ Coverage 72.88% 73.57% +0.69%
==========================================
Files 748 757 +9
Lines 92138 93094 +956
Branches 6976 6983 +7
==========================================
+ Hits 67157 68498 +1341
+ Misses 24981 24596 -385 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me unless we actually wanted to show/create the script/situation with rapid tumbling in setup.
Just my thoughts: We show the SIM_CMDBUS RW0 command without calling out what it is doing. Should it call out 'we'll loosely simulate a fault by... ' or something to that effect? Everything that goes through COSMOS seems like a spacecraft command, so it's important to explicitly mention we have a 'backdoor' to break the hardware simulations. Even if it takes too long for someone to do, it would be good to have some steps such as:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through and executed the scenario. Worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the steps as described and confirmed sim behavior followed as expected
Updates made per @dccutrig comments. |
Nothing really to walk through; to review, just read the document and ensure it both makes sense and is not missing anything.