Skip to content

[nasa/nos3#585] Star Tracker System Tests #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2025
Merged

Conversation

dacarter22
Copy link
Contributor

Added system tests for star tracker, checks that all commands work and verifies telemetry data comes down as expected

How to test:
pull nos3#585-ST_System_Tests branch
git submodule update --init --recursive

make clean
make
make launch
launch command and telemetry server and test runner
Load Generic_star_tracker tests
Run and verify all tests pass
Submodule merge requests:
https://github.com/nasa-itc/generic_star_tracker/tree/nos3%23585-ST_System_Tests
Closes #585

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (80725bb) to head (89413a1).
Report is 40 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #694      +/-   ##
==========================================
+ Coverage   72.88%   73.57%   +0.69%     
==========================================
  Files         748      757       +9     
  Lines       92138    93096     +958     
  Branches     6976     6983       +7     
==========================================
+ Hits        67157    68498    +1341     
+ Misses      24981    24598     -383     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dacarter22 dacarter22 changed the base branch from main to dev May 14, 2025 16:51
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed multiple times in a row

@msuder
Copy link
Contributor

msuder commented May 16, 2025

Ran according to instructions above and all tests passed.

Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code changes and they look good.

Copy link
Contributor

@zlynch2 zlynch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passes, and looks to be in system test format. approving.

@jlucas9 jlucas9 changed the title [nasa/nos3#585] ST_System_Tests [nasa/nos3#585] Star Tracker System Tests May 23, 2025
@jlucas9 jlucas9 merged commit b90154e into dev May 23, 2025
3 checks passed
@jlucas9 jlucas9 deleted the nos3#585-st_system_tests branch May 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star Tracker System Tests
6 participants