-
Notifications
You must be signed in to change notification settings - Fork 111
[nasa/nos3#585] Star Tracker System Tests #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #694 +/- ##
==========================================
+ Coverage 72.88% 73.57% +0.69%
==========================================
Files 748 757 +9
Lines 92138 93096 +958
Branches 6976 6983 +7
==========================================
+ Hits 67157 68498 +1341
+ Misses 24981 24598 -383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed multiple times in a row
Ran according to instructions above and all tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code changes and they look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passes, and looks to be in system test format. approving.
Added system tests for star tracker, checks that all commands work and verifies telemetry data comes down as expected
How to test:
pull nos3#585-ST_System_Tests branch
git submodule update --init --recursive
make clean
make
make launch
launch command and telemetry server and test runner
Load Generic_star_tracker tests
Run and verify all tests pass
Submodule merge requests:
https://github.com/nasa-itc/generic_star_tracker/tree/nos3%23585-ST_System_Tests
Closes #585