-
Notifications
You must be signed in to change notification settings - Fork 113
https://github.com/nasa/nos3/issues/697 - Protect FSS, star tracker, … #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #698 +/- ##
==========================================
+ Coverage 72.88% 73.94% +1.06%
==========================================
Files 748 761 +13
Lines 92138 93581 +1443
Branches 6976 6984 +8
==========================================
+ Hits 67157 69203 +2046
+ Misses 24981 24378 -603 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned all to 1 attempt and attempted to enable/toggle them, and all were consistently able to be enabled/toggled, from my testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msuder looks like this includes some of the initial shared memory functionality in the FSS, is that intentional or should I try to break this apart? |
@jlucas9 : Inclusion of the initial shared memory functionality was accidental but should cause no issues. |
…thruster, and sample data point from seg fault.
Depends on submodule pull requests:
Closes #697 .
To test:
Follow the instructions in issue #697 . Verify that at step 5 there is no star tracker sim crash. Set connection attempts to 1 for FSS and sample and go through the steps in issue #697 to enable FSS and sample and verify that those sims do not crash.