Skip to content

https://github.com/nasa/nos3/issues/697 - Protect FSS, star tracker, … #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

msuder
Copy link
Contributor

@msuder msuder commented May 20, 2025

…thruster, and sample data point from seg fault.

Depends on submodule pull requests:

  1. https://github.com/nasa/nos3/issues/697 - Protect FSS data point from… nasa-itc/generic_fss#11
  2. https://github.com/nasa/nos3/issues/697 - Protect star tracker data p… nasa-itc/generic_star_tracker#6
  3. https://github.com/nasa/nos3/issues/697 - Protect thruster data point… nasa-itc/generic_thruster#7
  4. https://github.com/nasa/nos3/issues/697 - Protect sample data point f… nasa-itc/sample#31
  5. https://github.com/nasa/nos3/issues/300 - Redo initial shared memory … nasa-itc/sim_common#10

Closes #697 .

To test:
Follow the instructions in issue #697 . Verify that at step 5 there is no star tracker sim crash. Set connection attempts to 1 for FSS and sample and go through the steps in issue #697 to enable FSS and sample and verify that those sims do not crash.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (80725bb) to head (898f45d).
Report is 42 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #698      +/-   ##
==========================================
+ Coverage   72.88%   73.94%   +1.06%     
==========================================
  Files         748      761      +13     
  Lines       92138    93581    +1443     
  Branches     6976     6984       +8     
==========================================
+ Hits        67157    69203    +2046     
+ Misses      24981    24378     -603     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned all to 1 attempt and attempted to enable/toggle them, and all were consistently able to be enabled/toggled, from my testing.

Copy link
Contributor

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Verified that changes fix star tracker RequestData checkout. No crash and prints data

@jlucas9
Copy link
Contributor

jlucas9 commented May 23, 2025

@msuder looks like this includes some of the initial shared memory functionality in the FSS, is that intentional or should I try to break this apart?

@msuder
Copy link
Contributor Author

msuder commented May 23, 2025

@jlucas9 : Inclusion of the initial shared memory functionality was accidental but should cause no issues.

@jlucas9 jlucas9 merged commit 7fdc27e into dev May 28, 2025
3 checks passed
@jlucas9 jlucas9 deleted the 697-bug---fix-crash-in-star-tracker-simulator branch May 28, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants