ci: harden ParkHub PHP Nido local CI follow-up#518
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c81e7d0ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Hardens the ParkHub local CI wrapper to prefer Nido when it supports queue builds, aligns legal-readiness wording/contracts with the updated queue-wrapper behavior, and refreshes ancillary strings/digests tied to scanning and site copy.
Changes:
- Add queue-wrapper selection (
nidowhen supported, otherwisefop) and update related legal-readiness contract checks. - Make the fop-local-ci failure-trap test more hermetic by stubbing additional tools used by wording checks.
- Refresh website/i18n copy and update the pinned Node base image digest used by the image-scan gate.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/test-legal-readiness-wording.sh | Expands scan paths and asserts new queue-wrapper wording/behavior is reflected in release/legal docs and CI script. |
| scripts/tests/test-fop-local-ci-failure-trap.sh | Adjusts test stubs (adds node, rg) to match tooling invoked by updated contract/wording gates. |
| resources/js/src/i18n/locales/en.ts | Updates marketing subtitle copy to “privacy controls” wording. |
| resources/js/src/i18n/locales/de.ts | Updates German marketing subtitle copy to “Datenschutz-Funktionen” wording. |
| parkhub-web/src/views/AdminFeatures.test.tsx | Updates mocked i18n text/assertions for compliance feature wording. |
| parkhub-web/src/pages/index.astro | Rewords SEO/OpenGraph/Twitter/structured-data descriptions away from “GDPR-compliant analytics” to “privacy-focused analytics/controls”. |
| parkhub-web/src/i18n/locales/en.ts | Updates welcome subtitle and “gdpr” section title to “Privacy controls...” wording. |
| parkhub-web/src/i18n/locales/de.ts | Updates welcome subtitle wording in the web app locale. |
| docs/release-checklist.md | Updates checklist wording to reference the Nido/fop legal catalog equivalence. |
| docs/legal-readiness.md | Updates legal-readiness text to reference the Nido/fop legal catalog equivalence. |
| docs/legal-readiness-parity.md | Updates parity doc to reference the Nido/fop legal catalog equivalence. |
| docs/deployment-readiness-record.md | Updates deployment record template field to include Nido/fop legal catalog command names. |
| Dockerfile | Refreshes the pinned mirrored Node 22-slim digest used by the image-scan gate. |
| COMPLIANCE-REPORT.md | Minor wording refresh clarifying templates/disclaimer language. |
| .github/scripts/fop-local-ci.sh | Adds queue-wrapper selection and updates messaging/comments to reflect either nido build or fop build. |
Summary
Verification
Notes