Skip to content

ci: harden ParkHub PHP Nido local CI follow-up#518

Merged
nash87 merged 13 commits into
mainfrom
t-6382-php-legal-followup
May 21, 2026
Merged

ci: harden ParkHub PHP Nido local CI follow-up#518
nash87 merged 13 commits into
mainfrom
t-6382-php-legal-followup

Conversation

@nash87
Copy link
Copy Markdown
Owner

@nash87 nash87 commented May 21, 2026

Summary

  • prefer nido build only when nido exposes build support, otherwise fall back to fop build
  • keep the legal wording and OpenAPI contract tests aligned with the queue wrapper behavior
  • refresh the Symfony YAML patch and mirrored Node base digest used by the Dockerfile image-scan gate

Verification

  • env NO_COLOR=true .github/scripts/fop-local-ci.sh --profile pr --post-status
  • .fop/reports/local-ci-pr-2c81e7d0ac4907fe2c2318472fd7a809f718be53.json state=success
  • pre-push hook accepted image-scan stamp .fop/image-scan-validated-240b20b36d.stamp and the SHA-keyed local CI report

Notes

  • GitHub-mode advisory scanners still report non-blocking zizmor, typos, and npm dev-dependency OSV findings; strict gates passed.

Copilot AI review requested due to automatic review settings May 21, 2026 12:06
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file ci CI/CD pipeline php PHP backend and Composer changes docs web labels May 21, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c81e7d0ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/tests/test-fop-local-ci-failure-trap.sh
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Hardens the ParkHub local CI wrapper to prefer Nido when it supports queue builds, aligns legal-readiness wording/contracts with the updated queue-wrapper behavior, and refreshes ancillary strings/digests tied to scanning and site copy.

Changes:

  • Add queue-wrapper selection (nido when supported, otherwise fop) and update related legal-readiness contract checks.
  • Make the fop-local-ci failure-trap test more hermetic by stubbing additional tools used by wording checks.
  • Refresh website/i18n copy and update the pinned Node base image digest used by the image-scan gate.

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/tests/test-legal-readiness-wording.sh Expands scan paths and asserts new queue-wrapper wording/behavior is reflected in release/legal docs and CI script.
scripts/tests/test-fop-local-ci-failure-trap.sh Adjusts test stubs (adds node, rg) to match tooling invoked by updated contract/wording gates.
resources/js/src/i18n/locales/en.ts Updates marketing subtitle copy to “privacy controls” wording.
resources/js/src/i18n/locales/de.ts Updates German marketing subtitle copy to “Datenschutz-Funktionen” wording.
parkhub-web/src/views/AdminFeatures.test.tsx Updates mocked i18n text/assertions for compliance feature wording.
parkhub-web/src/pages/index.astro Rewords SEO/OpenGraph/Twitter/structured-data descriptions away from “GDPR-compliant analytics” to “privacy-focused analytics/controls”.
parkhub-web/src/i18n/locales/en.ts Updates welcome subtitle and “gdpr” section title to “Privacy controls...” wording.
parkhub-web/src/i18n/locales/de.ts Updates welcome subtitle wording in the web app locale.
docs/release-checklist.md Updates checklist wording to reference the Nido/fop legal catalog equivalence.
docs/legal-readiness.md Updates legal-readiness text to reference the Nido/fop legal catalog equivalence.
docs/legal-readiness-parity.md Updates parity doc to reference the Nido/fop legal catalog equivalence.
docs/deployment-readiness-record.md Updates deployment record template field to include Nido/fop legal catalog command names.
Dockerfile Refreshes the pinned mirrored Node 22-slim digest used by the image-scan gate.
COMPLIANCE-REPORT.md Minor wording refresh clarifying templates/disclaimer language.
.github/scripts/fop-local-ci.sh Adds queue-wrapper selection and updates messaging/comments to reflect either nido build or fop build.

Comment thread .github/scripts/fop-local-ci.sh Outdated
Comment thread .github/scripts/fop-local-ci.sh Outdated
Comment thread scripts/tests/test-fop-local-ci-failure-trap.sh
@nash87 nash87 enabled auto-merge (squash) May 21, 2026 15:58
@nash87 nash87 merged commit bd0e54a into main May 21, 2026
29 checks passed
@nash87 nash87 deleted the t-6382-php-legal-followup branch May 21, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD pipeline dependencies Pull requests that update a dependency file docs php PHP backend and Composer changes web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants