Skip to content

Retry requests for updated objects 2 times #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
x189 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Retry requests for updated objects 2 times #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69f5e12
Retry requests for updated objects 2 times
May 12, 2015
7d977f4
Add missing methods in protocol
May 12, 2015
fde0424
Retry only requests for SurveyQuestion object
May 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions AFIncrementalStore/AFIncrementalStore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,10 @@
- (BOOL)authenticateRequest:(NSURLRequest *)request
fromResponseObject:(id)responseObject;

- (BOOL)shouldRetryRequest:(NSURLRequest *)request forUpdatedObject:(NSManagedObject *)updatedObject;

- (void)updateRetryMetadataForRequest:(NSURLRequest *)request forUpdateObject:(NSManagedObject *)updatedObject;

@end

///----------------
Expand Down
96 changes: 63 additions & 33 deletions AFIncrementalStore/AFIncrementalStore.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,7 @@ - (id)executeSaveChangesRequest:(NSSaveChangesRequest *)saveChangesRequest
withContext:(NSManagedObjectContext *)context
error:(NSError *__autoreleasing *)error
{

dispatch_group_t group = dispatch_group_create();
NSMutableArray *mutableOperations = [NSMutableArray array];
NSManagedObjectContext *backingContext = [self backingManagedObjectContext];
Expand Down Expand Up @@ -602,49 +603,24 @@ - (id)executeSaveChangesRequest:(NSSaveChangesRequest *)saveChangesRequest

if ([self.HTTPClient respondsToSelector:@selector(requestForUpdatedObject:)]) {
for (NSManagedObject *updatedObject in [saveChangesRequest updatedObjects]) {
NSManagedObjectContext *backingContext = [self backingManagedObjectContext];
NSManagedObjectID *backingObjectID = [self objectIDForBackingObjectForEntity:[updatedObject entity] withResourceIdentifier:AFResourceIdentifierFromReferenceObject([self referenceObjectForObjectID:updatedObject.objectID])];

NSURLRequest *request = [self.HTTPClient requestForUpdatedObject:updatedObject];
if (!request) {
[backingContext performBlockAndWait:^{
NSManagedObject *backingObject = [backingContext existingObjectWithID:backingObjectID error:nil];
[self updateBackingObject:backingObject withAttributeAndRelationshipValuesFromManagedObject:updatedObject];
[backingContext save:nil];
}];
continue;
return nil;
}

AFHTTPRequestOperation *operation = [self.HTTPClient HTTPRequestOperationWithRequest:request success:^(AFHTTPRequestOperation *operation, id responseObject) {
BOOL isAuthenticated = YES;
if ([self.HTTPClient respondsToSelector:@selector(authenticateRequest:fromResponseObject:)]) {
isAuthenticated = [self.HTTPClient authenticateRequest:request fromResponseObject:responseObject];
}
if (isAuthenticated) {
id representationOrArrayOfRepresentations = [self.HTTPClient representationOrArrayOfRepresentationsOfEntity:[updatedObject entity] fromResponseObject:responseObject];
if ([representationOrArrayOfRepresentations isKindOfClass:[NSDictionary class]]) {
NSDictionary *representation = (NSDictionary *)representationOrArrayOfRepresentations;
[updatedObject setValuesForKeysWithDictionary:[self.HTTPClient attributesForRepresentation:representation ofEntity:updatedObject.entity fromResponse:operation.response]];

[backingContext performBlockAndWait:^{
NSManagedObject *backingObject = [backingContext existingObjectWithID:backingObjectID error:nil];
[self updateBackingObject:backingObject withAttributeAndRelationshipValuesFromManagedObject:updatedObject];
[backingContext save:nil];
}];

[context refreshObject:updatedObject mergeChanges:YES];
}
}
else {
NSLog(@"Update Error: authentication failed");
[context refreshObject:updatedObject mergeChanges:NO];
}
} failure:^(AFHTTPRequestOperation *operation, NSError *error) {
NSLog(@"Update Error: %@", error);
[context refreshObject:updatedObject mergeChanges:NO];
}];
operation.completionGroup = group;

[mutableOperations addObject:operation];
AFHTTPRequestOperation *operation = [self operationForRequest:request updatedObject:updatedObject inManagedObjectContext:context];
if (operation) {
operation.completionGroup = group;
[mutableOperations addObject:operation];
}
}
}

Expand Down Expand Up @@ -695,6 +671,60 @@ - (id)executeSaveChangesRequest:(NSSaveChangesRequest *)saveChangesRequest
return [NSArray array];
}

- (AFHTTPRequestOperation *)operationForRequest:(NSURLRequest *)request updatedObject:(NSManagedObject *)updatedObject inManagedObjectContext:(NSManagedObjectContext *)context
{
NSManagedObjectContext *backingContext = [self backingManagedObjectContext];
NSManagedObjectID *backingObjectID = [self objectIDForBackingObjectForEntity:[updatedObject entity] withResourceIdentifier:AFResourceIdentifierFromReferenceObject([self referenceObjectForObjectID:updatedObject.objectID])];

AFHTTPRequestOperation *operation = [self.HTTPClient HTTPRequestOperationWithRequest:request success:^(AFHTTPRequestOperation *operation, id responseObject) {
BOOL shouldRetry = [updatedObject.entity.name isEqualToString:@"SurveyQuestion"] && [self.HTTPClient shouldRetryRequest:request forUpdatedObject:updatedObject];

BOOL isAuthenticated = YES;
if ([self.HTTPClient respondsToSelector:@selector(authenticateRequest:fromResponseObject:)]) {
isAuthenticated = [self.HTTPClient authenticateRequest:request fromResponseObject:responseObject];
}
if (isAuthenticated) {
id representationOrArrayOfRepresentations = [self.HTTPClient representationOrArrayOfRepresentationsOfEntity:[updatedObject entity] fromResponseObject:responseObject];
if ([representationOrArrayOfRepresentations isKindOfClass:[NSDictionary class]]) {
NSDictionary *representation = (NSDictionary *)representationOrArrayOfRepresentations;
[updatedObject setValuesForKeysWithDictionary:[self.HTTPClient attributesForRepresentation:representation ofEntity:updatedObject.entity fromResponse:operation.response]];

[backingContext performBlockAndWait:^{
NSManagedObject *backingObject = [backingContext existingObjectWithID:backingObjectID error:nil];
[self updateBackingObject:backingObject withAttributeAndRelationshipValuesFromManagedObject:updatedObject];
[backingContext save:nil];
}];

[context refreshObject:updatedObject mergeChanges:YES];
}
}
else {
if (shouldRetry) {
[self.HTTPClient updateRetryMetadataForRequest:request forUpdateObject:updatedObject];
AFHTTPRequestOperation *operation = [self operationForRequest:request updatedObject:updatedObject inManagedObjectContext:context];
[operation start];
}
else {
[context refreshObject:updatedObject mergeChanges:NO];
}
NSLog(@"Update Error: authentication failed");
}
} failure:^(AFHTTPRequestOperation *operation, NSError *error) {
BOOL shouldRetry = [updatedObject.entity.name isEqualToString:@"SurveyQuestion"] && [self.HTTPClient shouldRetryRequest:request forUpdatedObject:updatedObject];
NSLog(@"Update Error: %@", error);
if (shouldRetry) {
[self.HTTPClient updateRetryMetadataForRequest:request forUpdateObject:updatedObject];
AFHTTPRequestOperation *operation = [self operationForRequest:request updatedObject:updatedObject inManagedObjectContext:context];
[operation start];
}
else {
[context refreshObject:updatedObject mergeChanges:NO];
}
}];

return operation;
}

#pragma mark - NSIncrementalStore

- (BOOL)loadMetadata:(NSError *__autoreleasing *)error {
Expand Down