Skip to content

Properly visit types and expressions that are part of application spine #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2024
Merged

Properly visit types and expressions that are part of application spine #59

merged 1 commit into from
Dec 31, 2024

Conversation

fsoikin
Copy link
Contributor

@fsoikin fsoikin commented Dec 29, 2024 •
edited
Loading

I discovered this issue after noticing that some expressions don't get traversed properly.

Turns out, the spine traversal delegates directly to traverseType and traverseExpr instead of k.onType and k.onExpr respectively, so that the visitor never sees expressions that are function application parameters.

@natefaubion natefaubion merged commit c3fa31b into natefaubion:main Dec 31, 2024
1 check failed
@natefaubion
Copy link
Owner

Thanks!

@fsoikin fsoikin deleted the visit-app-spine branch January 2, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsoikin @natefaubion