Add counters draft client API #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
counters-client-api
branch
from
74a3299 to
cc17db9
Compare
ripienaar
reviewed
Jul 8, 2025
adr/ADR-49.md
Outdated
| // Loads a group of subjects from the same stream using a direct batch get, performs the | ||
| // calculation to combine these numbers client side | ||
| func LoadMulti(subjects []string, opts ...LoadOptions) ([]Entry, error) | ||
| /// Adds or subtracts a value from the counter, returning the new value. |
Collaborator
There was a problem hiding this comment.
spacing isnt right for these comments vs the functions, also weird with 3 slashes
Signed-off-by: Tomasz Pietrek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomasz Pietrek [email protected]